Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement + Fix: Stash Compact #3009

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Dec 1, 2024

What

https://discord.com/channels/997079228510117908/1312680137501704283
Fixes an issue where if you had both items and materials in stash, the warnings would stop being negated, and would show in duplicate. Also added a disablable warning text that informs users about the Empty Messages issue on first-boot if they have the filter off.

Images

image

Changelog Improvements

  • Added a warning for empty messages left behind by Stash Compact. - Daveed

Changelog Fixes

  • Fixed an issue where item and material stashes together would break Stash Compact. - Daveed

@github-actions github-actions bot added the Bug Fix Bug fixes label Dec 1, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 1, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the compact stash message is no longer getting sent
grafik
grafik

@hannibal002 hannibal002 merged commit 32058d2 into hannibal002:beta Dec 5, 2024
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Dec 5, 2024
@DavidArthurCole DavidArthurCole deleted the StashCompactFix branch December 5, 2024 00:09
@hannibal002 hannibal002 changed the title Fix + Improvement: Stash Compact Improvement + Fix: Stash Compact Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants